Skip to content

fix: avoid filesystem null reads#447

Merged
chubes4 merged 1 commit into
mainfrom
fix/cleanup-artifacts-filesystem-null
May 26, 2026
Merged

fix: avoid filesystem null reads#447
chubes4 merged 1 commit into
mainfrom
fix/cleanup-artifacts-filesystem-null

Conversation

@chubes4

@chubes4 chubes4 commented May 25, 2026

Copy link
Copy Markdown
Member

Summary

  • Replace uninitialized global WP_Filesystem reads with direct validated local file reads in runtime inspection and worktree HEAD parsing.
  • Keeps cleanup-artifacts and runtime read paths from fatalling when WP_Filesystem is not bootstrapped in CLI/smoke contexts.

Testing

  • php tests/smoke-worktree-cleanup-artifacts.php
  • php tests/smoke-worktree-cleanup-artifacts-bounded.php
  • php tests/smoke-wordpress-runtime-inspection.php
  • php -l inc/Runtime/WordPressRuntimeInspector.php
  • php -l inc/Workspace/WorkspaceWorktreeLifecycle.php

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Diagnosed the CLI fatal, drafted the minimal file-read fix, and ran targeted smoke/syntax checks.

@homeboy-ci

homeboy-ci Bot commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine-code

Lint

❌ lint — failed

  • phpstan — 5 finding(s)
  • Total: 5 finding(s)

ℹ️ Auto-fix: homeboy lint data-machine-code --path /home/runner/work/data-machine-code/data-machine-code --changed-since 446933a --fix (or homeboy refactor data-machine-code --path /home/runner/work/data-machine-code/data-machine-code --changed-since 446933a --from lint --write)
ℹ️ Some issues may require manual fixes
ℹ️ Full options: homeboy docs commands/lint
ℹ️ Save lint baseline: homeboy lint data-machine-code --baseline
Deep dive: homeboy lint data-machine-code --changed-since 446933a

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/26424542098

Test

✅ test — passed

ℹ️ No impacted tests found for --changed-since 446933a
ℹ️ Run full suite if needed: homeboy test data-machine-code
Deep dive: homeboy test data-machine-code --changed-since 446933a

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/26424542098

Audit

✅ audit — passed

Deep dive: homeboy audit data-machine-code --changed-since 446933a

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-code-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-code-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine-code/actions/runs/26424542098
Tooling versions
  • Homeboy CLI: homeboy 0.198.5+4bf2cd5
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: bb0c5bb4
  • Action: unknown@unknown

@chubes4 chubes4 merged commit 3c9a95c into main May 26, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chubes4